Fix negative strand CIGAR renderings on linear synteny view #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
force-pushed
the
fix_neg_strand_synteny_cigar
branch
from
fe3e185
to
7e3626b
Compare
cmdcolin
force-pushed
the
fix_neg_strand_synteny_cigar
branch
from
7e3626b
to
03ab944
Compare
|
image of the fix after this branch is applied |
…ld have strand===-1 but not apply
Codecov Report
@@ Coverage Diff @@
## main #3082 +/- ##
==========================================
- Coverage 61.35% 61.34% -0.02%
==========================================
Files 594 594
Lines 27277 27282 +5
Branches 6596 6601 +5
==========================================
- Hits 16736 16735 -1
- Misses 10243 10249 +6
Partials 298 298
Continue to review full report at Codecov.
|
cmdcolin
added
bug
cmdcolin
changed the title
|
has to use a special flag because we do not want to apply this to the read vs ref view, in that case the CIGAR is recorded in the reverse orientation already |
cmdcolin
force-pushed
the
fix_neg_strand_synteny_cigar
branch
from
93d9c7d
to
c2ca98e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspection of the DNA bases found that what was being rendered as the CIGAR (e.g. yellow and blue insertions/deletions) did not match up properly, so this fixes the issue